Some first steps towards serialization of sparse modules #5242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
For the record: The current problem is that the tests won't run, even though the following code works: R, (x, y) = QQ[:x, :y]
F = FreeMod(R, 2)
save("/tmp/mod.mrdi", F)
FF = load("/tmp/mod.mrdi")
v = x*F[1]
save("/tmp/elem.mrdi", v)
vv = load("/tmp/elem.mrdi")
I = ideal(R, [x, y])
II, inc = I*F
save("/tmp/subquo.mrdi", II)
III = load("/tmp/subquo.mrdi")
@test II == III
save("/tmp/subquoelem.mrdi", II[1])
vv = load("/tmp/subquoelem.mrdi")
@test II[1] == vv |
HechtiDerLachs
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this for a joint project with @simon-felten. At this point, it is not clear whether we keep this for internal purposes, or whether this can grow into an honest attempt to serializing modules. In either case, there were some issues which I couldn't solve and @antonydellavecchia suggested to make a draft PR so that we can discuss them in an orderly fashion.
@jankoboehm : If you are interested in maturing this, feel free to chime in. As I said: we can keep it internal to our project, otherwise.